virt_mshv: init vm after creation #2059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To configure custom VM features during VM creation, the create and initialize steps have been broken up in mshv-ioctls, starting with: 1afa433 mshv-ioctls: Don't initialize partition after creation So, any uses of v0.5.0 and newer versions of mshv-ioctls should explicitly initialize the vm after creation. Signed-off-by: Praveen K Paladugu <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Explicitly add a VM initialization step after creation to comply with the updated mshv-ioctls API (>= v0.5.0), which now separates creation and initialization.
- Adds an explicit vmfd.initialize() call after VM creation.
- Maps any initialization failure to an existing CreateVMFailed error variant.
smalis-msft
previously approved these changes
Oct 3, 2025
Co-authored-by: Copilot <[email protected]> Signed-off-by: Praveen K Paladugu <[email protected]>
praveen-pk
force-pushed
the
dom0/vm/init
branch
from
856f669 to
7220a78
Compare
smalis-msft
approved these changes
Oct 3, 2025
andyplank-msft
pushed a commit
to andyplank-msft/openvmm
that referenced
this pull request
Nov 4, 2025
To configure custom VM features during VM creation, the create and initialize steps have been broken up in mshv-ioctls, starting with: 1afa433 mshv-ioctls: Don't initialize partition after creation So, any uses of v0.5.0 and newer versions of mshv-ioctls should explicitly initialize the vm after creation. --------- Signed-off-by: Praveen K Paladugu <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To configure custom VM features during VM creation, the create and initialize steps have been broken up in mshv-ioctls, starting with:
1afa433 mshv-ioctls: Don't initialize partition after creation
So, any uses of v0.5.0 and newer versions of mshv-ioctls should explicitly initialize the vm after creation.